Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Anomaly Edits / Improvements #3365

Merged
merged 11 commits into from
Oct 14, 2024
Merged

Conversation

Erikafox
Copy link
Contributor

About The Pull Request

Reformats anomaly code to be mildly less 2023.

Anomalies now only have one core instead of aCore and bCore (what was i smoking). This core can receive multiple codes on the same frequency.
Some anomaly cores now have unique detonation effects for when they are activated outside of an anomaly. A few samples of this include: setting things on fire, radiation poisoning, disappearing.
Includes a new anomaly to try and balance out positive vs negative.
The new anomaly is called the Transfusion. It steals blood until it is no longer hungry, at which point it will give blood to those lacking in it.

Why It's Good For The Game

More sandboxy nature + decision making in conflict around anomalies.

Changelog

🆑 Erika Fox
add: Transfusion anomaly; yum! Blood!
add: Anomaly cores now have an effect when detonated out of the anomaly
add: new anomaly description fluff
/:cl:

@github-actions github-actions bot added DME Edit Code change Watch something violently break. labels Sep 15, 2024
thgvr
thgvr previously requested changes Sep 16, 2024
code/game/objects/effects/anomalies/_anomalies.dm Outdated Show resolved Hide resolved
@@ -2,9 +2,9 @@
/obj/effect/anomaly/bluespace
name = "jumper"
icon_state = "bluespace"
desc = "A mysterious anomaly that causes teleportation around it."
desc = "A hole in the fabric of bluespace, perforating reality around it."
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kinda meh on this change

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean. What else teleports things lol. I think its fine for it to be blue-space.

@@ -18,6 +19,8 @@
var/turf/open/our_turf = get_turf(src)
if(istype(our_turf))
hallucination_pulse(our_turf, 5)
pixel_x = pixel_x + clamp(rand(-5, 5), -16, 16)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what's this for?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes the anomaly shift around (like the desc implies)

@@ -0,0 +1,69 @@
/obj/effect/anomaly/transfusion
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After looking through this anomaly and its effects I can't say it will be very fun, as blood is pretty expensive as is

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm curious to see how it gets used before calling it. I think there's some potential in the core's detonation and for really bad situations.

Co-authored-by: Theos <[email protected]>
Signed-off-by: Erika Fox <[email protected]>
@Erikafox Erikafox requested a review from thgvr October 2, 2024 19:04
@Erikafox Erikafox requested a review from a team as a code owner October 3, 2024 18:20
@github-actions github-actions bot added the Sprites A bikeshed full of soulless bikes. label Oct 3, 2024
@rye-rice rye-rice enabled auto-merge October 7, 2024 04:00
@rye-rice rye-rice dismissed thgvr’s stale review October 7, 2024 04:01

lesbian merge

@rye-rice rye-rice added this pull request to the merge queue Oct 7, 2024
@rye-rice rye-rice removed this pull request from the merge queue due to a manual request Oct 7, 2024
@thgvr thgvr added this pull request to the merge queue Oct 14, 2024
Merged via the queue into shiptest-ss13:master with commit 56c392f Oct 14, 2024
14 checks passed
zimon9 pushed a commit to zimon9/Shiptest-PR-testing that referenced this pull request Oct 29, 2024
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->

## About The Pull Request
Reformats anomaly code to be mildly less 2023. 

Anomalies now only have one core instead of aCore and bCore (what was i
smoking). This core can receive multiple codes on the *same* frequency.
Some anomaly cores now have unique detonation effects for when they are
activated outside of an anomaly. A few samples of this include: setting
things on fire, radiation poisoning, disappearing.
Includes a new anomaly to try and balance out positive vs negative. 
The new anomaly is called the Transfusion. It steals blood until it is
no longer hungry, at which point it will give blood to those lacking in
it.
<!-- Describe The Pull Request. Please be sure every change is
documented or this can delay review and even discourage maintainers from
merging your PR! -->

## Why It's Good For The Game
More sandboxy nature + decision making in conflict around anomalies.
<!-- Please add a short description of why you think these changes would
benefit the game. If you can't justify it in words, it might not be
worth adding. -->

## Changelog

:cl: Erika Fox
add: Transfusion anomaly; yum! Blood!
add: Anomaly cores now have an effect when detonated out of the anomaly
add: new anomaly description fluff
/:cl:

<!-- Both :cl:'s are required for the changelog to work! You can put
your name to the right of the first :cl: if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->

---------

Signed-off-by: Erika Fox <[email protected]>
Co-authored-by: Theos <[email protected]>
zimon9 pushed a commit to zimon9/Shiptest-PR-testing that referenced this pull request Oct 29, 2024
@Erikafox Erikafox deleted the anomaly_edits branch December 19, 2024 01:14
MrCat15352 pushed a commit to MrCat15352/MrCat that referenced this pull request Dec 27, 2024
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->

## About The Pull Request
Reformats anomaly code to be mildly less 2023. 

Anomalies now only have one core instead of aCore and bCore (what was i
smoking). This core can receive multiple codes on the *same* frequency.
Some anomaly cores now have unique detonation effects for when they are
activated outside of an anomaly. A few samples of this include: setting
things on fire, radiation poisoning, disappearing.
Includes a new anomaly to try and balance out positive vs negative. 
The new anomaly is called the Transfusion. It steals blood until it is
no longer hungry, at which point it will give blood to those lacking in
it.
<!-- Describe The Pull Request. Please be sure every change is
documented or this can delay review and even discourage maintainers from
merging your PR! -->

## Why It's Good For The Game
More sandboxy nature + decision making in conflict around anomalies.
<!-- Please add a short description of why you think these changes would
benefit the game. If you can't justify it in words, it might not be
worth adding. -->

## Changelog

:cl: Erika Fox
add: Transfusion anomaly; yum! Blood!
add: Anomaly cores now have an effect when detonated out of the anomaly
add: new anomaly description fluff
/:cl:

<!-- Both :cl:'s are required for the changelog to work! You can put
your name to the right of the first :cl: if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->

---------

Signed-off-by: Erika Fox <[email protected]>
Co-authored-by: Theos <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code change Watch something violently break. DME Edit Sprites A bikeshed full of soulless bikes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants